fix: don't fail checks when the PR comment cannot be posted (fork PRs) - #66
Merged
Conversation
Fork PRs run shared workflows with a read-only GITHUB_TOKEN, so the sticky-comment POST/PATCH returns HTTP 403 and the whole job fails even though every test passed. Treat 401/403 on the comment update as a warning instead of a failure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR comment update workflow moves into ChangesPR comment update
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork PRs run the shared workflows with a read-only
GITHUB_TOKEN. The sticky "OVOS PR Checks" comment update then fails with HTTP 403 and takes the whole job down with it, even when all tests passed — currently making every fork PR in every org show 7 red checks (e.g. JarbasHiveMind/HiveMind-core#138/#139/#143).This treats 401/403 on the comment POST/PATCH as a warning: the comment is cosmetic and must never fail the check itself. All other HTTP errors still propagate.
🤖 Generated with Claude Code
Summary by CodeRabbit