Add duration to utterance_start message - #146
Conversation
|
Warning Review limit reached
Next review available in: 52 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughImports a sound-duration helper and computes the duration of each played audio (stripping a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #146 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 8 8
Lines 1013 1018 +5
=====================================
- Misses 1013 1018 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ovos_audio/playback.py`:
- Around line 134-136: Wrap the call to get_sound_duration in a local try/except
so a failure there doesn't abort playback: catch exceptions around
get_sound_duration(data.replace('file://', '')), set
message.data["duration"]=None on error (or leave unset), optionally log the
exception, and then continue to emit
self.bus.emit(message.forward("recognizer_loop:utterance_start", message.data))
and call play_audio as before; this change should be made inside the _play
method around the get_sound_duration usage to ensure playback proceeds even if
duration computation fails.
|
@femelo can you please rebase so the new CI bot and tests run? |
Add duration to utterance_start message
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.