fix: floor ovos-spec-tools at the release that ships intent_topics - #427
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The automated sentinels have completed their watch. 💂♂️I've aggregated the results of the automated checks for this PR below. 📋 Repo HealthChecking the repo's mental health (aka developer happiness). 😊 ✅ All required files present. Latest Version: ✅ 🔍 LintHere's the lowdown on the latest automated check. 📉 ❌ ruff: issues found — see job log 🏷️ Release PreviewPolishing the release notes for the big debut! 🎀 Current:
✅ PR title follows conventional commit format. 🚀 Release Channel Compatibility Predicted next version:
⚖️ License CheckEnsuring no copyleft violations in this PR. ⬅️ ✅ No license violations found. Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed. 📊 CoverageMeasuring the footprint of your testing efforts. 👣 ✅ 85.3% total coverage Files below 80% coverage (5 files)
Full report: download the 🔒 Security (pip-audit)Checking if we're following security best practices. 📏 ✅ No known vulnerabilities found (47 packages scanned). 🔨 Build TestsThe build engine is firing on all cylinders. 🏎️ ✅ All versions pass
The automation engine never sleeps. 🚂 |
ovos_utils.fakebusimportsovos_spec_tools.intent_topics, but the dependency floor (ovos-spec-tools>=0.16.1a2) predates that module: any environment whose resolver lands on an old-but-floor-satisfying spec-tools (observed via a downstream's stale<1.0.0cap resolving spec-tools 0.18.0a1) gets an unimportable ovos-utils, and only a real install catches it. The floor moves to>=1.6.0a2, the first release whoseintent_topicscarries the post-refactor shape the import needs — verified by installing exactly the floor version and importingcanonical_intent_topic.