fix(ci): boot the Tier 3 image via NVMe, not virtio - #165
Merged
Conversation
The Raspberry Pi kernel ships no virtio drivers (modules.builtin has none and the initramfs carries none), so /dev/vda2 never appears and boot drops to the initramfs shell. nvme, xhci-pci and usb-storage are built in — attach the disk as an NVMe device (root=/dev/nvme0n1p2) and the user-mode NIC as a USB device.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Tier 3 aarch64 QEMU smoke test now boots from an emulated NVMe disk and uses a USB network device instead of virtio storage and networking. ChangesQEMU boot configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 3 run 29209587280 reached the initramfs but
ALERT! /dev/vda2 does not exist. Inspection of the image'smodules.builtin/initramfs shows the Pi kernel has no virtio drivers at all, whilenvme,xhci-pci,usb-storageandsd_modare built in (they're the Pi 4/5 boot-media drivers). Switch the qemu disk to an NVMe device (root=/dev/nvme0n1p2) and the user-mode NIC tousb-netbehindqemu-xhci.🤖 Generated with Claude Code
Summary by CodeRabbit