Repository navigation
implement worklfow rn state api migration - #42
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates workflow-run transitions to permission-specific APIs and centralizes validation, dispatch, and feedback.
Changes:
- Adds shared transition utilities and regression tests.
- Updates single, batch, and rerun transition flows.
- Requires comments for new workflow-run states.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
workflowRunStateTransitions.ts |
Adds transition utilities. |
workflowRunStateTransitions.test.ts |
Tests transition behavior. |
WorkflowRunDetailsContext.tsx |
Uses global validation endpoint. |
WorkflowRunsBatchStateTransitionModal.tsx |
Migrates batch transitions. |
WorkflowRunRerunModal.tsx |
Disables invalid deprecation. |
WorkflowRunRerunModal.test.tsx |
Tests deprecation availability. |
WorkflowRunDetailsTimeline.tsx |
Migrates timeline transitions. |
WorkflowRunDetailsPageHeader.tsx |
Migrates rerun deprecation. |
workflows.api.ts |
Defines new API hooks. |
CustomStateDialog.tsx |
Supports required comments. |
CustomStateDialog.test.tsx |
Tests required comment markup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+100
to
+103
| () => | ||
| new Set<string>( | ||
| getAvailableWorkflowRunStateTransitions(validationMap, []).map(({ value }) => value) | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update workflow-run state transitions to use the new permission-specific API endpoints.
Changes
GET /api/v1/workflowrun/state/get_states_transition_validation_map/POST /api/v1/workflowrun/state/cancel/POST /api/v1/workflowrun/state/deprecate/POST /api/v1/workflowrun/state/resolve/workflowrunOrcabusIds.Testing
Added regression tests for: