Skip to content

Bump Downloader from 5.9.5 to 5.9.6 - #451

Merged
Otiel merged 1 commit into
masterfrom
dependabot/nuget/src/BandcampDownloader.IntegrationTests/Downloader-5.9.6
Sep 14, 2026
Merged

Otiel merged 1 commit into
masterfrom
dependabot/nuget/src/BandcampDownloader.IntegrationTests/Downloader-5.9.6

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Updated Downloader from 5.9.5 to 5.9.6.

Release notes

Sourced from Downloader's releases.

5.9.6

Highlights

A download now always reports how it ended.

🐛 Fixes

  • A download could finish without ever raising DownloadFileCompleted. StartDownload ended in one of four branches, and the last one — an "unexpected" terminal state — only logged a warning and returned. For anything driven by the events (rather than only awaiting the task) that meant the download never ended: no error, no file, nothing to retry, and a UI left showing it as still in progress. That branch now always sends a completion signal.
  • Pausing exactly as the last bytes arrive no longer throws the download away. A Pause() that lands after every byte has been received leaves the status Paused with nothing left to do — a finished download. It is now reported as Completed instead of falling into the unexpected-state branch and being discarded.
  • Any other unexpected terminal state is reported as Failed with an IncompleteDownloadException naming the state and the byte counts, so the cause is visible instead of silent.

🔧 Under the hood

  • New integration tests (CompletionSignalTest) cover all three terminal paths — completed, cancelled, and paused-at-the-finish-line. The last one fails against 5.9.5.

Found while tracing a download manager whose row stayed "downloading" forever against a server that refused its requests (Downloader.Desktop #​9).

What's Changed

Full Changelog: bezzad/Downloader@v5.9.5...v5.9.6

Commits viewable in compare view.

@dependabot dependabot Bot added .NET Pull requests that update .NET code dependencies Pull requests that update a dependency file labels Aug 31, 2026
@dependabot
dependabot Bot force-pushed the dependabot/nuget/src/BandcampDownloader.IntegrationTests/Downloader-5.9.6 branch from deb2e01 to 8043f5f Compare September 14, 2026 10:18
@Otiel
Otiel enabled auto-merge September 14, 2026 10:33
---
updated-dependencies:
- dependency-name: Downloader
  dependency-version: 5.9.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/nuget/src/BandcampDownloader.IntegrationTests/Downloader-5.9.6 branch from 8043f5f to 922f0b9 Compare September 14, 2026 10:35
@Otiel
Otiel merged commit 50410d7 into master Sep 14, 2026
5 checks passed
@Otiel
Otiel deleted the dependabot/nuget/src/BandcampDownloader.IntegrationTests/Downloader-5.9.6 branch September 14, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant