fix(nimlsp): move Nim version check to run after initialize#182
Merged
Conversation
Previously, was called at the start of , before the client had sent an initialize request. This caused potential protocol violations or confused clients. Now the version check is deferred to run only after receiving and handling the initialize request, ensuring it adheres to the LSP handshake and avoids premature messages.
Owner
|
Ooh, good call. That should definitely happen later in the pipe. As for the failing tests, maybe the 1.4 and 1.2 tests can simply be removed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, was called at the start of , before the client had sent an initialize request. This caused potential protocol violations or confused clients.
Now the version check is deferred to run only after receiving and handling the initialize request, ensuring it adheres to the LSP handshake and avoids premature messages.