fix partial commit bug from 1.12.5 - #609
Closed
jsgarmon wants to merge 1 commit into
Closed
Conversation
jsgarmon
force-pushed
the
jsg-1.12.5-bug-fix
branch
from
May 26, 2026 18:42
65b0f78 to
d0f1e1b
Compare
This was referenced Jun 10, 2026
Collaborator
|
Closing as dup of #625. Thank you for the submission however as you are completely correct about both the bug, and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previous change incorrectly used
febefore it is defined. Should be appending to root.Motivation and Context
Seeing errors when running partial commits, stems from changes from 1.12.5
How Has This Been Tested?
Currently patching local systems with this change for partial commits to succeed
Screenshots (if appropriate)
Types of changes
Checklist