#674: Add project country question - #684
Merged
Merged
Conversation
samrichca
marked this pull request as draft
July 23, 2026 19:05
JamesTLopez
requested changes
Sep 1, 2026
JamesTLopez
left a comment
JamesTLopez
left a comment
Contributor
There was a problem hiding this comment.
Pretty much ready to go, just a couple of small things 🕶️
| options={GC_STANDARD_GEOGRAPHIC_AREAS.map((areas) => { | ||
| return { value: areas.iso, label: areas.en }; | ||
| })} | ||
| initialValue={'CAN'} |
Contributor
There was a problem hiding this comment.
initialValue is CAN but it is not displayed in the textbox adding the default to RHF should do the trick:
projectCountry: state.fields.projectCountry ?? 'CAN'
| })} | ||
| initialValue={'CAN'} | ||
| rule={rule} | ||
| required |
Contributor
There was a problem hiding this comment.
required is not actually applying the red asterisk, I think this is a bug in Select component itself.
Changing that line to this should work
const fieldLabel = props.required ? RequiredLabel(props.label) : props.label;…ian-Genome-Library/daco into feat/674-jurisdiction-question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a country field to the project page in DACO.
Related Issues
Description of Changes
DACO API
countryfield for projects in a user's applicationDACO UI
countryfield to the projects page in a user's applicationData Model
countryfield to the data model for applicationsSpecial Instructions
Before running these changes, you will need to migrate your databases:
Readiness Checklist
#{TicketNumber}: Description of Changesapi,ui,data-model, etc.)feature,fix,chore,documentation).env.schemafile and documented in the README