#690: Resolve isPCGLDac accounts cant see sign and submit - #692
Open
JamesTLopez wants to merge 2 commits into
Open
#690: Resolve isPCGLDac accounts cant see sign and submit#692JamesTLopez wants to merge 2 commits into
JamesTLopez wants to merge 2 commits into
Conversation
leoraba
reviewed
Aug 20, 2026
| <RepSignatureView signatureData={data} signatureLoading={isLoading} setOpenModal={setOpenModal} /> | ||
| )} | ||
| {(isDacChair || isDacMember) && ( | ||
| {(isDacChair || isDacMember || user?.isPcglDac) && ( |
Contributor
There was a problem hiding this comment.
this seems that any PCGL Dac now will be allowed to sign others's DAC's applications. Will this be case or this scenario is restricted at router level?
Contributor
Author
There was a problem hiding this comment.
The signature will be disabled for the PCGL DAC. The logic to disable that is in the signature component itself, which looks if the user has the appropriate permissions to do so, otherwise disabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve a bug where local DAC accounts could not see sign & submit pages of applications they are not a dacChair of. They should be able to read the entire application.
Related Issues
Description of Changes
UI
Readiness Checklist
#{TicketNumber}: Description of Changesapi,ui,data-model, etc.)feature,fix,chore,documentation).env.schemafile and documented in the README