Skip to content

Added codes for missing error messages and error table to readme - #76

Open
kishan79 wants to merge 4 commits into
mainfrom
NFTFactoryFix
Open

Added codes for missing error messages and error table to readme#76
kishan79 wants to merge 4 commits into
mainfrom
NFTFactoryFix

Conversation

@kishan79

@kishan79 kishan79 commented Mar 1, 2022

Copy link
Copy Markdown
Member

No description provided.

@kishan79 kishan79 linked an issue Mar 1, 2022 that may be closed by this pull request
@kishan79
kishan79 requested a review from vishaldantuluri March 1, 2022 16:21
@parva-jain

Copy link
Copy Markdown
Contributor

I have gone through the changes. Can we improve on the Reason column for errors 2 and 4 in the readme as it looks more like remediation than reason. Else everything looks good to me @kishan79 @techpandora @vishaldantuluri

@parva-jain

Copy link
Copy Markdown
Contributor

@kishan79 checkout the changes

@kishan79 kishan79 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parva-jain Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit: NFTFactoryContract Missing Error messages

2 participants