Skip to content

Add high contrast visuals into the menu-bar#160

Open
cshadsy wants to merge 12 commits into
PenguinMod:developfrom
cshadsy:develop
Open

Add high contrast visuals into the menu-bar#160
cshadsy wants to merge 12 commits into
PenguinMod:developfrom
cshadsy:develop

Conversation

@cshadsy

@cshadsy cshadsy commented Sep 21, 2025

Copy link
Copy Markdown

There are people who prefer Light Mode over dark mode such as me, but need high contrast visuals.
This PR adds an eye icon beside the language carat icon which toggles high contrast visuals. Additionally, a window variable is applied called "isHighContrast" that the other repos could possibly use to also apply these visuals.

@cshadsy

cshadsy commented Sep 21, 2025

Copy link
Copy Markdown
Author
image

@SharkPool-SP

Copy link
Copy Markdown

eye icon should be beside the moon icon

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

ah ok, ill get done in a bit

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

moved, should be ready to merge
remember "isHighContrast" window variable for studio heh

@SharkPool-SP

Copy link
Copy Markdown

Shouldn't be a window variable, just set it as a attribute to document like dark mode. That way it's easier to apply for css

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

oh ok

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

anything else that should be done

@SharkPool-SP

Copy link
Copy Markdown

Should be it unless you want to make it into a menu that combines dark and contrast mode into 1 dropdown button.

@Ianyourgod

Copy link
Copy Markdown
Member

Personally, I would prefer if we had something like turbowarp's settings menu so we don't clutter the top bar.

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

i was gonna do that

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

let me familiarize myself with scratch's "Amazing" programming skills (this entire file sucks)

@SharkPool-SP

Copy link
Copy Markdown

I agree but this is just a temporary solution till we port over the changes

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

idfk how these damn menus work thank you scratch programmers

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

i tried and it don't wanna open i hate this codebase

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

tdhrjhbsdbsdfjjhgzsd

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

i give up on the menu thing

@cshadsy

cshadsy commented Sep 22, 2025

Copy link
Copy Markdown
Author

it should be ready, the css theme="high-contrast" (should be able to) be used to apply to other things like paint and blocks and etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants