Skip to content

epic/271-trait-viewer - #1487

Open
chaneylc wants to merge 15 commits into
mainfrom
epic/271-trait-viewer
Open

epic/271-trait-viewer#1487
chaneylc wants to merge 15 commits into
mainfrom
epic/271-trait-viewer

Conversation

@chaneylc

@chaneylc chaneylc commented Jun 10, 2026

Copy link
Copy Markdown
Member

field dependent trait lists

closes #271

Change Type

  • ADDITION (non-breaking change that adds functionality)
  • CHANGE (fix or feature that alters existing functionality)
  • FIX (non-breaking change that resolves an issue)
  • OTHER (use only for changes like tooling, build system, CI, docs, etc.)

Release Note


@chaneylc
chaneylc requested a review from trife June 10, 2026 18:40
chaneylc added 4 commits June 15, 2026 16:10
updated trait list item border
fixed trait picker new triat dialog transition on cancel

@trife trife left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I somehow changed the trait order from the field details screen. Both traits screens have height first, but field details lists location first which is what actually loads in Collect
  • Remove the index number in the traits lists
  • When no traits exist, going back to details and forward reloads all traits visually but all the traits are still actually missing (can't go to Collect).
  • Trait details visibility settings are accessible/saved in the main list- syncing field-traits matches the current value.
  • Add a per field option that keeps the sub-list in sync with the main list (presence/absence and visibility). This can be a toggle that lives in the field details header card.
  • In the Traits card in field details, let's just list how many traits in the same summary text as the collect/export instead of the icons and expandable list
  • Remove text format from trait listitems
  • Need a way of indicating that the sub trait list is different from the main trait list- preferably in the header
  • Trait picker search should match other search layouts (full pill round), add selected should match other areas (e.g. brapi import), and add selected shouldn't show until traits are selected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TraitViewerActivity

2 participants