epic/271-trait-viewer - #1487
Open
chaneylc wants to merge 15 commits into
Open
Conversation
updated trait list item border
fixed trait picker new triat dialog transition on cancel
… trait list sort improved sort scrolling
trife
requested changes
Jun 26, 2026
Member
There was a problem hiding this comment.
- I somehow changed the trait order from the field details screen. Both traits screens have height first, but field details lists location first which is what actually loads in Collect
- Remove the index number in the traits lists
- When no traits exist, going back to details and forward reloads all traits visually but all the traits are still actually missing (can't go to Collect).
- Trait details visibility settings are accessible/saved in the main list- syncing field-traits matches the current value.
- Add a per field option that keeps the sub-list in sync with the main list (presence/absence and visibility). This can be a toggle that lives in the field details header card.
- In the Traits card in field details, let's just list how many traits in the same summary text as the collect/export instead of the icons and expandable list
- Remove text format from trait listitems
- Need a way of indicating that the sub trait list is different from the main trait list- preferably in the header
- Trait picker search should match other search layouts (full pill round), add selected should match other areas (e.g. brapi import), and add selected shouldn't show until traits are selected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
field dependent trait lists
closes #271
Change Type
ADDITION(non-breaking change that adds functionality)CHANGE(fix or feature that alters existing functionality)FIX(non-breaking change that resolves an issue)OTHER(use only for changes like tooling, build system, CI, docs, etc.)Release Note