Skip to content

Removed G+ Button#4624

Open
locked-fg wants to merge 2 commits intoPhilJay:masterfrom
locked-fg:locked-fg-removeGooglePlus
Open

Removed G+ Button#4624
locked-fg wants to merge 2 commits intoPhilJay:masterfrom
locked-fg:locked-fg-removeGooglePlus

Conversation

@locked-fg
Copy link
Copy Markdown

G+ is no more. Just removed the G+ Share-Button / Link

PR Checklist:

  • I have tested this extensively and it does not break any existing behavior.
  • I have added/updated examples and tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Removed the G+ Button as GogglePlus is shut down

G+ is no more. Just removed the G+ Share-Button / Link
Comment thread README.md Outdated
<br/>

<h2 id="social">Social Media :fire:</h2>
<h2 id="
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong

@MGaetan89
Copy link
Copy Markdown

I think you should also remove the googleplus_icon.png file

- fixed the id="social" issue
@locked-fg
Copy link
Copy Markdown
Author

locked-fg commented Aug 19, 2019

Damn Right! Removed the icon and put the css-id back in (no clue how/why I removed it).
Is it okay to have 2 commits or should I squash them together?

@MGaetan89 MGaetan89 mentioned this pull request Nov 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants