Fix/maven central portal migration#764
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe root Maven POM updates the ChangesMaven GPG Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PMD (7.25.0)pom.xml[ERROR] Cannot load ruleset .coderabbit-pmd-ruleset.xml: Cannot resolve rule/ruleset reference '.coderabbit-pmd-ruleset.xml'. Make sure the resource is a valid file or URL and is on the CLASSPATH. Use --debug (or a fine log level) to see the current classpath. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
feign-reactor-parent forced maven-gpg-plugin to sign with gpg.keyname
3EEF24C7 and set gpg.defaultKeyring=false. Under maven-gpg-plugin 3.2.5
that combination failed to resolve the key in CI ("gpg: skipped
3EEF24C7: No secret key"), even though the org GPG_PRIVATE_KEY (which is
that key) was imported by setup-java -- the root module, which sets no
keyname, signed fine with the default key.
- Drop the hardcoded gpg.keyname/defaultKeyring (plus deprecated
useagent/lockMode) so every module signs with the default imported
key, matching the root module that already worked.
- Bump maven-gpg-plugin 3.2.5 -> 3.2.8 to align with the proven
testcontainers-spring-boot release setup.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pom.xml`:
- Around line 64-81: The CircleCI Maven settings server id is still mismatched
with the release configuration. Update the `<id>` in
`.circleci/circleci.settings.xml` from the old value to `central` so it matches
the `server-id: central` and `-P central` usage in the release flow, and ensure
the Maven deploy configuration in the CircleCI settings template references the
same server entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a04ba92c-10fa-40e3-9a1a-ebb5ac582d13
📒 Files selected for processing (2)
feign-reactor-parent/pom.xmlpom.xml
💤 Files with no reviewable changes (1)
- feign-reactor-parent/pom.xml
| <id>central</id> | ||
| <url>https://central.sonatype.com/repository/maven-snapshots/</url> | ||
| </snapshotRepository> | ||
| <repository> | ||
| <id>ossrh</id> | ||
| <url>https://oss.sonatype.org/service/local/staging/deploy/maven2/</url> | ||
| </repository> | ||
| </distributionManagement> | ||
|
|
||
| <profiles> | ||
| <profile> | ||
| <id>ossrh</id> | ||
| <id>central</id> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.sonatype.plugins</groupId> | ||
| <artifactId>nexus-staging-maven-plugin</artifactId> | ||
| <version>${nexus-staging-maven-plugin.version}</version> | ||
| <groupId>org.sonatype.central</groupId> | ||
| <artifactId>central-publishing-maven-plugin</artifactId> | ||
| <version>${central-publishing-maven-plugin.version}</version> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> | ||
| <autoReleaseAfterClose>true</autoReleaseAfterClose> | ||
| <publishingServerId>central</publishingServerId> | ||
| <autoPublish>true</autoPublish> |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Old OSSRH references =="
rg -n -C2 'ossrh|-Possrh|nexus-staging-maven-plugin|<id>ossrh</id>|serverId>ossrh|server-id ossrh' .
echo
echo "== New Central references =="
rg -n -C2 'central-publishing-maven-plugin|publishingServerId|<id>central</id>|-Pcentral' .
echo
echo "== Candidate workflow / settings files =="
fd -HI '(^pom\.xml$|^settings.*\.xml$|.*\.ya?ml$|.*\.sh$|^README.*$)' .Repository: PlaytikaOSS/feign-reactive
Length of output: 191
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Files of interest =="
fd -HI '(^pom\.xml$|^settings.*\.xml$|.*\.ya?ml$|.*\.sh$|^README.*$|^CONTRIBUTING.*$|^release.*$|^publish.*$)' .
echo
echo "== OSSRH / nexus-staging references =="
rg -n -C2 'ossrh|-Possrh|nexus-staging-maven-plugin|serverId>ossrh|<id>ossrh</id>' . || true
echo
echo "== Central publishing references =="
rg -n -C2 'central-publishing-maven-plugin|publishingServerId|<id>central</id>|-Pcentral|central.sonatype.com' . || true
echo
echo "== Workflow and settings candidates =="
fd -HI '(\.github/workflows/.*\.ya?ml$|settings.*\.xml$|.*\.sh$|README.*$|CONTRIBUTING.*$)' .Repository: PlaytikaOSS/feign-reactive
Length of output: 3384
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Search for ossrh / central in candidate files =="
rg -n -C2 'ossrh|-Possrh|nexus-staging-maven-plugin|publishingServerId|central|serverId|settings.xml' \
.circleci/circleci.settings.xml \
.github/workflows/maven.yml \
.github/workflows/release.yml \
README.md \
feign-reactor-benchmarks/README.md \
feign-reactor-spring-configuration/README.md \
|| true
echo
echo "== Read workflow/settings snippets =="
for f in .circleci/circleci.settings.xml .github/workflows/maven.yml .github/workflows/release.yml README.md; do
echo "--- $f ---"
sed -n '1,220p' "$f"
echo
doneRepository: PlaytikaOSS/feign-reactive
Length of output: 14087
Update the CircleCI Maven settings server id to central
.circleci/circleci.settings.xml still defines <id>ossrh</id>, while the release workflow now uses server-id: central and -P central. If CircleCI uses this settings template, deploy will look for the wrong server entry.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pom.xml` around lines 64 - 81, The CircleCI Maven settings server id is still
mismatched with the release configuration. Update the `<id>` in
`.circleci/circleci.settings.xml` from the old value to `central` so it matches
the `server-id: central` and `-P central` usage in the release flow, and ensure
the Maven deploy configuration in the CircleCI settings template references the
same server entry.
224a421 to
38d4e57
Compare
1 participant
Summary by CodeRabbit