Fix/maven central portal migration#765
Merged
Merged
Conversation
added 2 commits
June 29, 2026 11:55
feign-reactor-parent forced maven-gpg-plugin to sign with gpg.keyname
3EEF24C7 and set gpg.defaultKeyring=false. Under maven-gpg-plugin 3.2.5
that combination failed to resolve the key in CI ("gpg: skipped
3EEF24C7: No secret key"), even though the org GPG_PRIVATE_KEY (which is
that key) was imported by setup-java -- the root module, which sets no
keyname, signed fine with the default key.
- Drop the hardcoded gpg.keyname/defaultKeyring (plus deprecated
useagent/lockMode) so every module signs with the default imported
key, matching the root module that already worked.
- Bump maven-gpg-plugin 3.2.5 -> 3.2.8 to align with the proven
testcontainers-spring-boot release setup.
The Central Publisher Portal rejected the 5.0.0 deployment with
"Project name is missing" for every module. The Portal requires a
<name> in each published POM, and Maven does not inherit <name> from
the parent, so the 18 modules without one failed validation (only
feign-reactor-core, feign-reactor-test and the root declared a name).
Add <name>{artifactId}</name> to each remaining module, matching the
testcontainers-spring-boot convention that already publishes to the
Portal successfully.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughAdds a ChangesAdd Maven name elements to module POMs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit