Azure, MacOS, Ubuntu improvements#1199
Azure, MacOS, Ubuntu improvements#1199Koi-3088 wants to merge 4 commits intoPokemonAutomation:mainfrom
Conversation
- Use a .dmg installer for MacOS. - Implement gstreamer for Ubuntu. - Improve Azure build times for all OS. - Fix double-zip issue for Azure. - Add ability to run multiple instances on MacOS via terminal by running `open -n /Applications/SerialPrograms/SerialPrograms.app --args --profile <some profile name>`
|
Azure app bundle (Ubuntu AppImage, MacOS .app/.dmg) and Windows build artifacts work fine on my end. Local build works fine as well. But should be tested/verified since some build environment variables might be quirky/weird, and I don't want to break local builds or introduce regressions. |
Mysticial
left a comment
Mysticial
left a comment
There was a problem hiding this comment.
Holy shit this resource stuff is getting messy. lol
…es are being used.
Yeah, a little bit. Which is why I wanted to just rip the bandaid off for application bundles while jw is dealing with the brunt of it. |
| cd "$CACHE_DIR" | ||
| if [ "$BUILD_TYPE" = "PrivateBeta" ]; then | ||
| echo "=== Creating password-protected archive for PrivateBeta ===" | ||
| 7z a -tzip -mx=9 "-p$ARTIFACT_PASSWORD" -mem=AES256 "$ZIP_NAME" "$DMG_NAME" |
There was a problem hiding this comment.
I have an issue extracting the zip with the default MacOS Archive Utility, had to install third party tools to do so. Archive Utility supposedly doesn't support AES256. Archive Utility doesn't tell you what failed exactly so users likely assume the password is incorrect
There was a problem hiding this comment.
Can just require 7zip for private beta for all OS, since all are password-protected in the same way. It's also trivial to install and has powerful functionality. What would otherwise be the proposed change that preserves the behavior?
There was a problem hiding this comment.
Also note that this is not new to this PR, the 7zip step was just consolidated into the building stage with the introduction of the .dmg file (was previously in the macos-notarization.yml which was removed).
EDIT: We do have a pinned message in the Discord beta channel that mentions the 7zip requirement.
There was a problem hiding this comment.
I wasn't aware that 7zip started supporting MacOS. It is only available as CLI though which might be non-intuitive for non-technical users. Given that it's just for the beta and that the command to run can just be given, it's likely not a big deal. Users can also just install Unarchiver instead.
The proposed change to support Archive Utility would be to use a different format when encrypting with 7zip or use Apple's aea to keep AES
There was a problem hiding this comment.
Did some reading. Seems like if I were to use Apple's aea I would have to do it via terminal if I want a custom password, but then users would also have to use terminal to extract, which kind of defeats the purpose.
Could remove -mem=AES256 to use MacOS default encryption (should be ZipCrypto?) or explicitly specify it, not sure if there's a difference. Probably latter is better.
I'll test it locally using p7zip and will update the PR if Archive Utility looks happy. AES256 is probably overkill anyways.
There was a problem hiding this comment.
Seems to work on my end, pushed the requested change.
…er-side convenience.
4 participants
Resourcesfolder for all OS.open -n /Applications/SerialPrograms/SerialPrograms.app --args --profile <some profile name>