Fix Switch 1 timings for RNG resets#1220
Open
theastrogoth wants to merge 1 commit intoPokemonAutomation:mainfrom
Open
Fix Switch 1 timings for RNG resets#1220theastrogoth wants to merge 1 commit intoPokemonAutomation:mainfrom
theastrogoth wants to merge 1 commit intoPokemonAutomation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the PR spam...
I hadn't thoroughly tested Switch 1 resets after some of the recent changes -- it turns out that the only real difference is that, after the reset sequence, my Switch 1 resumes the game at a point roughly 750ms earlier than my Switch 2.
This PR adds a delay to account for this difference, and it was successfully tested on both consoles. With luck, this will be the last of the fixes for blind resets.