Cross-check gate access across enabled RPCs before wrapping an epoch key - #53
Merged
Merged
Conversation
The key responder decided access from a single user-chosen RPC, so one lying endpoint could make it hand an epoch key to a non-member (fail-closed against an outage, wide open against a lie). checkAccessQuorum now reads checkAccess across the enabled RPCs: agreement decides, a lone/custom RPC is accepted (never a disabled endpoint), a disagreement is tie-broken by the remaining enabled ones, and an unbreakable tie fails closed and warns the user. All known RPCs ship enabled so the quorum has members to work with; normal reads still hit one at a time.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key responder decided access from a single user-chosen RPC, so one lying
endpoint could make it hand an epoch key to a non-member (fail-closed against an
outage, wide open against a lie). checkAccessQuorum now reads checkAccess across
the enabled RPCs: agreement decides, a lone/custom RPC is accepted (never a
disabled endpoint), a disagreement is tie-broken by the remaining enabled ones,
and an unbreakable tie fails closed and warns the user. All known RPCs ship
enabled so the quorum has members to work with; normal reads still hit one at a
time.