Repository navigation
Conversation
4 of 5 tasks
eli-r-ph
marked this pull request as ready for review
October 10, 2026 04:03
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Capture v1 requires
$session_idand$window_idto be strings and rejects the whole request otherwise, so every v1 SDK lifts only a string and drops any other value. The drop was silent in all three SDKs. They now agree to log a warning on every drop.CaptureEvent::from_event_atlifts both keys throughlift_string_property. A string, including"", is sent unchanged.bool, number, array or object value is dropped withposthog-rs: dropping $session_id: a number value is not a string. The warning names the key and the type, never the value.nullcounts as unset and drops without a warning, the same rule options use.Stacked on #279, which also changes
from_event_at.💚 How did you test it?
event_session_window_lift_only_stringscapturestracingoutput for string, empty string,null, number, bool, array and object values. It checks the lifted value, that both keys leaveproperties, the warning text per key and type, that no value text reaches the log, and that strings andnulllog nothing.cargo test --workspace,cargo test --no-default-features(with and withouterror-tracking),cargo clippy -- -D warnings,cargo fmt --checkandscripts/check-public-api.shpass locally.📝 Checklist
If releasing new changes
sampo addto generate a changeset fileHuman-driven (agent-assisted).