Repository navigation
fix: unique event uuids, future timestamps, blank ids - #287
Merged
Merged
Conversation
…lank ids as anonymous A cloned or reused Event no longer sends one uuid twice: the client assigns the uuid when it takes the event, unless set_uuid was called. set_timestamp no longer rejects future timestamps; PostHog clamps them. Event::new with an empty or whitespace-only distinct id creates an anonymous event. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eli-r-ph
marked this pull request as ready for review
October 13, 2026 05:28
eli-r-ph
changed the title
marandaneto
approved these changes
Oct 16, 2026
marandaneto
left a comment
marandaneto
left a comment
Member
There was a problem hiding this comment.
The code looks good; no qualifying findings. Verdict: correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Three event rules differed from the other PostHog SDKs, and two of them lost events.
Changes
Event::new.Eventtwice no longer sends one uuid twice, which PostHog rejects.set_uuidis still sent as given.set_timestampaccepts future timestamps; PostHog clamps far-future ones. Its signature is unchanged.Event::newwith an empty or whitespace-only distinct ID makes an anonymous event, likeEvent::new_anon. PostHog used to drop it.💚 How did you test it?
Event::newagain fails the new test.🤖 Generated with Claude Code