Repository navigation
fix(devex): count a topic click as picking the tile it opens on - #184
Merged
Merged
Conversation
Since #176 only a click on a tile or PR armed the 1.5 s open-read dwell. Skimming topics through the sidebar and dwelling on a one-tile topic (for example a merged PR) left everything unread, so each one had to be marked by hand (owner feedback 2026-10-12, revises Q1 from 2026-10-10). - A click on a topic (sidebar row, Archive drawer, topic link in Instructions) now picks the tile and PR the topic opens on: it arms the dwell and counts as a visit for Mac pings, like a click on that tile. - The pick waits while the topic's tiles load and never carries over to a later app pick in that topic (e.g. the next tile after a mark). - Re-clicking the open topic behaves like re-clicking the open tile: an open that marked nothing starts over, a mark keeps its Undo. - Search's first match, back/forward, the next tile after one left, an app pick turned user-like and the agent toast's topic still never mark. All server-side openedRead guards stay as they are.
PostHog Review · Standard · reviewed
|
| Step | Status | Result |
|---|---|---|
| Prepare the diff | done | 9 files |
| Main review and lenses | done | 0 issues |
| Merge and cap | done | 0 → 0 |
| Publish | done | Nothing to post |
|
PostHog Review alpha 🦔 If you find any issues helpful - please reply "valid", "invalid", etc., for evaluation purposes 🙏 |
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
| if (userPick === null || selected.prKey === null || selected.prKey !== userPick.prKey) { | ||
| return false; | ||
| } | ||
| return !selected.auto || userPick.fromTopicClick; |
There was a problem hiding this comment.
P2 · Expire topic-click picks when the automatic selection moves
Click a topic opening PR A, search for PR B, then clear the search. userPick still names A, so pickedByUser authorizes the restored automatic selection and useOpenedRead starts a fresh dwell without another click. This breaks the own-pick rule and marks A if writes were unlocked meanwhile; expire the topic pick when selection moves.
Contributor
Author
There was a problem hiding this comment.
valid — fixed in 38cfc36: a topic-click pick now ends once the pane shows another PR (topicPickExpired).
A topic click armed the dwell for the PR it opened on. A search could move the pane to its first match and, once cleared, bring that PR back on its own, which restarted the dwell without a new click. The topic pick now ends as soon as the pane shows another PR. Tile and PR picks are unchanged: their PR is the nav entry itself. Raised by the PostHog Review bot on #184.
Merged
webjunkie
added a commit
that referenced
this pull request
Oct 12, 2026
Patch release on top of 0.28.0 with two board fixes: a topic click counts as picking the tile it opens on again, so the dwell marks it read (#184), and a PR with a standing change request from the viewer stays under Open instead of folding into Dealt with (#185). Every package.json goes to 0.28.1 and the 0.28.1 changelog section gets its date for the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner feedback after #176: skimming topics in the sidebar and dwelling on a one-tile topic (say, a merged PR) no longer marked anything, so each one needed Mark read by hand. This revises Q1 from 2026-10-10.
New rule
A click on a topic counts as the user's pick of the tile and PR the topic opens on. The dwell and the Mac ping visit treat it like a click on that tile. All the existing guards stay (server openedRead verdict, writes lock, menus holding the dwell, Undo, once per open, no mark that turns wanted later).
Edge cases
What counts as a topic click
Sidebar rows, the Archive drawer (same handler) and the topic links in Instructions. All three are direct clicks that open a topic. The breadcrumb is not a link, so nothing there.
Mac pings
useTileVisit follows the same rule, so the tile a topic click opens on also clears its pings. Keeps the two consistent: if PostPile marks it read after the dwell, its pings should go too.
DESIGN.md, NEXT.md (new 2026-10-12 decision, Q1 marked revised), apps/desktop/CLAUDE.md and CHANGELOG are updated.