Repository navigation
fix(devex): keep a PR you requested changes on out of Dealt with - #185
Merged
Merged
Conversation
Owner report 2026-10-12: a topic folded all its tiles under Dealt with, including an open PR where the viewer requested changes and the author had not addressed them yet. isPrDone treated a handled open PR whose turn was not the viewer's as done, and a standing change request that waits on the author passed that check. BOARD-A-14's holdingPrLine only patched over it in the topic header. New rule "Your change request holds the PR open": an open PR whose viewer's newest verdict asks for changes (viewerRequestedChanges, same notion as the Changes you requested tier) and that they have not approved since is never done. It ends only when the verdict changes (approve, dismissed) or the PR is merged or closed. NOT_YOURS does not end it. Snooze still parks it. Read state stays separate from done: the old done rule lives on as nothingAskedOfViewer, exposed as TileAfterRead.nothingAsked, and the open-read dwell reads that (OpenedReadInput.nothingAskedAfterRead, renamed from doneAfterRead). So a held PR waiting on the author still gets its thread marked read and handled, while its button says "Mark read", never "Done for now". The property spec gets the same split (expectedNothingAsked, expectedChangeRequestHold). holdingPrLine stays: a read team mention or a not-yours review request can still leave an ask PR under Dealt with.
PostHog Review · Standard · reviewed
|
| Step | Status | Result |
|---|---|---|
| Prepare the diff | done | 29 files |
| Main review and lenses | done | 0 issues |
| Merge and cap | done | 0 → 0 |
| Publish | done | Nothing to post |
…est-holds-pr-open # Conflicts: # CHANGELOG.md # NEXT.md
Merged
webjunkie
added a commit
that referenced
this pull request
Oct 12, 2026
Patch release on top of 0.28.0 with two board fixes: a topic click counts as picking the tile it opens on again, so the dwell marks it read (#184), and a PR with a standing change request from the viewer stays under Open instead of folding into Dealt with (#185). Every package.json goes to 0.28.1 and the 0.28.1 changelog section gets its date for the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A topic folded every tile under Dealt with, including an open PR where you had requested changes and the author hadn't addressed them yet. So the one PR that still mattered was hidden. Cause:
isPrDonecalled a handled open PR done as long as it wasn't your move, and a change request waiting on the author passes that.New rule: your change request holds the PR open (owner call, 2026-10-12)
Read state vs. done
nothingAskedOfViewer. A mark-read now shows it asTileAfterRead.nothingAsked, and the open-read check uses that (doneAfterReadwas renamed tonothingAskedAfterRead).nothingAskedmatches the spec.holdingPrLine (BOARD-A-14)
Kept. With this change the Changes you requested case can't happen anymore, but a team mention that has been read, or a review request the glance calls not yours, can still leave an ask PR under Dealt with. Its comment and tests now use those cases.
Fake mode: sample #1963 (the change request waiting on tove) now shows under Open. The fake engine test checks this.