Repository navigation
Conversation
A directory watch can emit 'error' after fs.watch returns, for example when macOS runs out of FSEvents. With no listener, Node throws and the wizard crashes. The watcher now logs the error, closes that watch and keeps polling. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: Bug fix: small behavior change. Review.
Problem
The JSON file watcher pairs
fs.watchwith polling. A directory watch can emiterrorafterfs.watchreturns, for example when macOS runs out of FSEvents. The watcher had noerrorlistener, so Node threw and the wizard crashed, even though polling alone would have kept working.Changes
startFileWatcherinsrc/lib/file-watcher.tsnow listens forerroron each directory watch.Test plan
src/ui/tui/hooks/__tests__/file-watcher.test.tsemitserroron the directory watch, then writes the file and expects the update through polling. It fails onmainwith the thrown error and passes with the fix.pnpm typecheck,pnpm lint(0 errors),pnpm vitest run(201 files, 3356 tests) andpnpm test:archall pass.Created with PostHog Desktop