Repository navigation
Conversation
The skill scanner's glob matched extensions case-sensitively, so a file like PAYLOAD.TXT inside an installed skill was never read or scanned. The glob now ignores case, and a real-filesystem test covers the Bash skill-install hook. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope: Bug fix: one-line behavior change. Review.
Problem
The skill scanner finds files to scan with a glob that matches extensions case-sensitively. A file like
PAYLOAD.TXTinside an installed skill never matches*.txt, so YARA never reads it. The Bash skill-install hook andscanInstalledSkillboth go through this scanner, so both miss it.Changes
scanSkillFilespassescaseSensitiveMatch: falseto fast-glob. Extensions now match in any case, on every filesystem.Test plan
src/agent/__tests__/skill-case-scan.test.tsbuilds a real skill directory withSKILL.mdand a poisonedPAYLOAD.TXT, then runs the Bash skill-install hook on it. The hook now terminates. Without the fix, the test fails because the file is never scanned.pnpm typecheck,pnpm lint(0 errors),pnpm vitest run(202 files, 3356 tests) andpnpm test:archpass.Created with PostHog Desktop