Repository navigation
Conversation
Use the shared helper in the CI pre-run hook so missing-framework failures include the same app-root and setup guidance as the other integration flows. Cover the abort before framework configuration or skill selection.
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Test against a Context Mill branch:
Add Results will be posted here when complete. |
edwinyjlim
approved these changes
Sep 24, 2026
| expect.objectContaining({ | ||
| code: ErrorCodes.DetectNoFramework, | ||
| outroData: expect.objectContaining({ | ||
| instruction: expect.stringContaining("app's root directory"), |
Member
There was a problem hiding this comment.
the copy changed. let's not pin the copy in the test
Collaborator
Author
There was a problem hiding this comment.
yah yeeet remove tests. Will do a sweep actually these really piss me off too :kek:
Collaborator
Author
There was a problem hiding this comment.
Will do separate PR to do this sweep
The test pinned the outro instruction's wording, which the shared abortNoFrameworkDetected helper words differently. It now checks the DetectNoFramework code only. Generated-By: PostHog Desktop Task-Id: d14e92bb-6ee1-49b5-8502-39cb80079589
gewenyu99
merged commit Sep 24, 2026
f681acb
into
codex/fix-integration-no-framework
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Error tracking's CI/headless path still defines its own
DetectNoFrameworkabort. When detection finds no framework, it gives only a terse failure message instead of the app-root and setup guidance used by integration and replay vision.Stacked on #1347; this PR targets
codex/fix-integration-no-frameworkuntil the shared helper lands onmain.Changes
Use
abortNoFrameworkDetected()in error tracking's CI pre-run hook. Keep the early return before framework configuration or skill selection, and cover it with a regression test.This was the only remaining direct
DetectNoFrameworkabort in the programs. Other detection outcomes have their own prerequisite errors or project-picking flows.Test plan
pnpm typecheckpassed.pnpm buildpassed, including CLI and warlock smoke checks.git diff --checkpassed.LLM context
Codex audited the other programs for adoption of the shared helper from #1347 and implemented this follow-up.