Conversation
mkleczek
marked this pull request as draft
June 24, 2026 05:32
mkleczek
force-pushed
the
push-wkklkmnwrrxr
branch
4 times, most recently
from
July 9, 2026 04:07
508c400 to
a4e7904
Compare
Member
|
@mkleczek Please rebase 🙏 |
Document how to start a replacement PostgREST process on the same public host and port when server-reuseport is enabled. Include the admin server port requirement and readiness-check sequence so upgrade handovers can be validated before stopping the old process.
mkleczek
force-pushed
the
push-wkklkmnwrrxr
branch
from
July 18, 2026 09:29
a4e7904 to
7a80683
Compare
Comment on lines
+53
to
+65
| - This works for host and port based servers. It does not apply when | ||
| :ref:`server-unix-socket` is used. | ||
| - If :ref:`server-reuseport` is disabled, the new process will fail to start | ||
| with an address-in-use error and the old process will keep serving requests. | ||
| - If :ref:`server-reuseport` is enabled on an operating system that does not | ||
| support ``SO_REUSEPORT``, PostgREST will fail to start because the | ||
| configuration is not supported on that platform. | ||
| - If the new process uses the same :ref:`admin-server-port` as the old process, | ||
| it will fail to start because that admin port is already in use. | ||
| - Each PostgREST process has its own :ref:`db-pool`. During the handover, the | ||
| total possible database connections can temporarily double. | ||
| - The old and new processes may both serve requests for a short time. Database | ||
| migrations should be compatible with both versions while they overlap. |
Member
There was a problem hiding this comment.
Putting the most important considerations first. Also removing ones that I think are redundant with the previous paragraphs.
Suggested change
| - This works for host and port based servers. It does not apply when | |
| :ref:`server-unix-socket` is used. | |
| - If :ref:`server-reuseport` is disabled, the new process will fail to start | |
| with an address-in-use error and the old process will keep serving requests. | |
| - If :ref:`server-reuseport` is enabled on an operating system that does not | |
| support ``SO_REUSEPORT``, PostgREST will fail to start because the | |
| configuration is not supported on that platform. | |
| - If the new process uses the same :ref:`admin-server-port` as the old process, | |
| it will fail to start because that admin port is already in use. | |
| - Each PostgREST process has its own :ref:`db-pool`. During the handover, the | |
| total possible database connections can temporarily double. | |
| - The old and new processes may both serve requests for a short time. Database | |
| migrations should be compatible with both versions while they overlap. | |
| - Each PostgREST process has its own :ref:`db-pool`. During the handover, the | |
| total possible database connections can temporarily double. | |
| - The old and new processes may both serve requests for a short time. Database | |
| migrations should be compatible with both versions while they overlap. | |
| - This works for host and port based servers. It does not apply when | |
| :ref:`server-unix-socket` is used. |
steve-chavez
approved these changes
Jul 21, 2026
steve-chavez
left a comment
steve-chavez
left a comment
Member
There was a problem hiding this comment.
This LGTM once the feedback is addressed.
Collaborator
Author
Let's discuss if this one should be abandoned in favor of #5112 |
Member
|
Since #5112 won't be merged for this release:
|
Member
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.