Make discriminator argument multiple - #52
Merged
Merged
Conversation
jolelievre
force-pushed
the
discimination-array
branch
from
February 16, 2026 15:59
cd3ea00 to
db169da
Compare
mattgoud
approved these changes
Feb 16, 2026
Quetzacoalt91
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need multiple possibilities to check if a comment is a license comment
Use case
On the core we changed the default comment from a long one to a short one PrestaShop/PrestaShop#40768
The problem is that old files from previous PRs have the old header, which is incompatible with the new one and detected as an error. But the fixer part doesn't recognize the old header as a license header and prefixes the new one above it.
That's why we need multiple ways to identify the license comment, so we can use the header-stamp to migrate them by specifyng and old and a new discriminator.