Restore MapsFactory::getLeafletLayerDefinitions(), removed in 14.0.0 - #937
Merged
Merged
Conversation
Fixes #936 Maps 13.1.0 added the accessor together with the $egMapsLeafletLayerDefinitions setting (#921). The Semantic Result Formats filtered format resolves custom layer names in its `map view layers` parameter through it, guarded by method_exists() so Maps stays an optional dependency. 14.0.0 removed the accessor, so on 14.x the guard fails and custom layer names are silently skipped, the same degradation as Maps not being installed at all. The restored accessor reads the effective settings, so unlike the 13.1.x one it also returns definitions set on the MediaWiki:Maps page. It mirrors LeafletService, keeping LeafletLayerDefinitions as the single normalization and hardening path, and the MediaWiki:Maps read stays lazy, at parse time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VHABGwcoKTWgFWUEToN58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #936
Maps 13.1.0 added the accessor together with the $egMapsLeafletLayerDefinitions setting (#921). The Semantic Result Formats filtered format resolves custom layer names in its
map view layersparameter through it, guarded by method_exists() so Maps stays an optional dependency. 14.0.0 removed the accessor, so on 14.x the guard fails and custom layer names are silently skipped, the same degradation as Maps not being installed at all.The restored accessor reads the effective settings, so unlike the 13.1.x one it also returns definitions set on the MediaWiki:Maps page. It mirrors LeafletService, keeping LeafletLayerDefinitions as the single normalization and hardening path, and the MediaWiki:Maps read stays lazy, at parse time.