Tighten naming conventions wording - #1297
Draft
JeroenDeDauw wants to merge 1 commit into
Draft
Conversation
Fold the "store" rule's scope (identifiers, docs, discussion) into the instruction it restated, dropping the trailing justification a reference page does not carry, and give the third bullet the lead-in the other two have. Rename the collisions heading to read as a noun phrase. No rule changes what it permits or forbids. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #1295, which merged before the text pass ran. Prose only; no rule changes what it permits or forbids.
onlyis retained, so the restriction is unchanged.## Known collisions, unresolvedbecomes## Known unresolved collisions, the phrasing Add code-facing naming conventions doc #1295's own description uses. Nothing in either repo links to the page or its anchors.Considered, omitted:
<X>Pickeris defined twice, under "Data access and selection" and again under "Vue component suffixes". Kept, because the first is what makes the Lookup/Picker collision rule below it actionable.The pass also checked every identifier the page names against the code. Two of its claims did not hold at #1295's merge commit, and both are already answered elsewhere:
SubjectLookupnamed both a read port and a Vue selection widget, which #1296 has since renamed; and "Graph Store" is cited as a Glossary term the glossary does not yet define, which #1294 adds. Neither needs a change here.