Add a generic manual operator action framework - #1203
Draft
j0nch wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManualOperatorfrontend for awaiting work performed by a personmove_resource()for acknowledged manual transfers with PLR resource-model reconciliationResource moves
ManualOperator.move_resource()validates the modeled source and destination before prompting, leaves the resource assigned to its source while the operator works, and updates the model only after successful acknowledgement. It revalidates before assignment to avoid overwriting state that changed while the request was pending. Cancellation, reported failure, and provider exceptions leave the resource model unchanged.The operation uses PLR's standard resource-assignment machinery, including default
ResourceHolderchild positioning and optional explicit destination coordinates. Requests contain transport-safe resource names rather than liveResourceobjects.Scope
This initial implementation intentionally has no EventBus dependency. It establishes the manual-operation and provider contracts independently; event integration can be considered separately once the base API is reviewed.
Testing
python3 -m unittest pylabrobot.manual_operator.manual_operator_tests -vpython3 -m compileall -q pylabrobot/manual_operatorgit diff --check