feat: run classic Harbor on stock 0.20.0 + OpenShift custom env - #67
Open
ikrispin wants to merge 1 commit into
Open
feat: run classic Harbor on stock 0.20.0 + OpenShift custom env#67ikrispin wants to merge 1 commit into
ikrispin wants to merge 1 commit into
Conversation
Replace skills_eval_corrections fork with PyPI Harbor and AEH-style OpenShiftEnvironment via import_path / docker_image (APPENG-5914).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval_engine: harbor) off theskills_eval_correctionsfork onto pinned upstream Harbor (harbor==0.20.0) plus the AEH-style custom OpenShift environment (abevalflow.harbor_extensions.openshift_environment:OpenShiftEnvironment).task.tomldocker_imageand selects the env withenvironment.import_path/--environment-import-path(notenvironment.type: openshiftor forkkwargs.image_ref).eval-base(Dockerfile.base+build_base_image.sh) to install stock Harbor + pinned AEH k8s env; removeharbor-fork-url/harbor-fork-revisionpipeline params; refresh docs and unit tests.Closes / tracks: APPENG-5914 (parent APPENG-4901).
Motivation
Classic Harbor CI depended on a Harbor fork for OpenShift. AEH already runs stock Harbor with a custom env plugin. This aligns classic A/B with that model so we can track upstream Harbor without maintaining the fork or adopting upstream’s oc/SCC OpenShift backend.
What changed
generate_eval_config.py: prebuilt →import_path+docker_image; local-build →type: dockerOPENSHIFT_ENVIRONMENT_IMPORT_PATHinabevalflow/harbor_extensionstemplates/Dockerfile.base:harbor==0.20.0, AEH SHAff8b8301…, bakeabevalflowevaluate/harbor-eval: PyPI Harbor fallback +--environment-import-path; drop fork paramsDocs/harbor_custom_env.md; fork/OpenShift docs redirectedtest_generate_eval_config.py; addedtest_openshift_environment.pyOut of scope (per ticket): upstream
type: openshift(oc/SCC),harbor run -d, dropping DB columnharbor_fork_revision.Test plan
eval-base:latestandeval-base:local-envwith Harbor 0.20.0itay-evalflowhello-world/ Harbor / prebuiltfeat/harbor-custom-envfromhttps://github.com/ikrispin/ABEvalFlow.git0.20.0,docker_imageset,--environment-import-path, noskills_eval_corrections, treatment/control mean reward 1.0ab-eval-flowand confirm monitoring CI still healthy--environment-import-pathwith Harbor’s--envflagNotes for reviewers
origin/main(Harbor-only commitd6cb164).Successful run:
