Skip to content

feat: run classic Harbor on stock 0.20.0 + OpenShift custom env - #67

Open
ikrispin wants to merge 1 commit into
RHEcosystemAppEng:mainfrom
ikrispin:feat/harbor-custom-env
Open

feat: run classic Harbor on stock 0.20.0 + OpenShift custom env#67
ikrispin wants to merge 1 commit into
RHEcosystemAppEng:mainfrom
ikrispin:feat/harbor-custom-env

Conversation

@ikrispin

@ikrispin ikrispin commented Aug 5, 2026

Copy link
Copy Markdown

Summary

  • Migrate classic Harbor A/B (eval_engine: harbor) off the skills_eval_corrections fork onto pinned upstream Harbor (harbor==0.20.0) plus the AEH-style custom OpenShift environment (abevalflow.harbor_extensions.openshift_environment:OpenShiftEnvironment).
  • Prebuilt CI now hands off trial images via task.toml docker_image and selects the env with environment.import_path / --environment-import-path (not environment.type: openshift or fork kwargs.image_ref).
  • Update eval-base (Dockerfile.base + build_base_image.sh) to install stock Harbor + pinned AEH k8s env; remove harbor-fork-url / harbor-fork-revision pipeline params; refresh docs and unit tests.

Closes / tracks: APPENG-5914 (parent APPENG-4901).

Motivation

Classic Harbor CI depended on a Harbor fork for OpenShift. AEH already runs stock Harbor with a custom env plugin. This aligns classic A/B with that model so we can track upstream Harbor without maintaining the fork or adopting upstream’s oc/SCC OpenShift backend.

What changed

Area Change
Config generate_eval_config.py: prebuilt → import_path + docker_image; local-build → type: docker
Contract Shared OPENSHIFT_ENVIRONMENT_IMPORT_PATH in abevalflow/harbor_extensions
Images templates/Dockerfile.base: harbor==0.20.0, AEH SHA ff8b8301…, bake abevalflow
Pipeline evaluate / harbor-eval: PyPI Harbor fallback + --environment-import-path; drop fork params
Docs New Docs/harbor_custom_env.md; fork/OpenShift docs redirected
Tests Updated test_generate_eval_config.py; added test_openshift_environment.py

Out of scope (per ticket): upstream type: openshift (oc/SCC), harbor run -d, dropping DB column harbor_fork_revision.

Test plan

  • Unit tests for config generation + OpenShiftEnvironment import path
  • Rebuild/push eval-base:latest and eval-base:local-env with Harbor 0.20.0
  • Unbaked cluster smoke (pipeline clones feature branch; no baked sources image):
  • After merge: apply updated Tasks/Pipelines in shared ab-eval-flow and confirm monitoring CI still healthy
  • Optional follow-up: replace deprecated --environment-import-path with Harbor’s --env flag

Notes for reviewers

  • Feature branch is based on origin/main (Harbor-only commit d6cb164).
  • Smoke used namespace-local apply tweaks (litellm URL, image refs, scheduling) that are not part of this PR.

Successful run:
Screenshot From 2026-08-05 16-36-59

Replace skills_eval_corrections fork with PyPI Harbor and AEH-style
OpenShiftEnvironment via import_path / docker_image (APPENG-5914).
@ikrispin
ikrispin requested a review from GuyZivRH August 5, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant