Repository navigation
Conversation
Editing a recurring transaction overwrote its start date with whatever selectedDateProvider held (today, or the date of the last transaction opened in the add page), since transactionSelect never sets it and the edit page shows the start date as read-only. For monthly recurrences this also shifted the day of the month future payments are inserted on. Selecting "Never" as end date was also ignored, because RecurringTransaction.copy() treated a null toDate as "keep the current value". Use the same _unset sentinel already used by Transaction.copy().
mikev-cw
approved these changes
Oct 8, 2026
mikev-cw
left a comment
Collaborator
There was a problem hiding this comment.
nice catch, thank you!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Description
Editing a recurring transaction changed its start date to whatever
selectedDateProviderheld: today, or the date of the last transaction opened in the add page. That also moved the day of the month future payments are inserted on. Selecting "Never" as end date was ignored, so the old end date was kept.Closes: #545
📱 Changes
RecurringTransactionsNotifier.updateTransactionno longer setsfromDate. The start date is read-only on the edit page, so the stored value is kept.RecurringTransaction.copy()can now settoDatetonull, using the same_unsetsentinelTransaction.copy()already uses forid.test/providers/recurring_transactions_provider_test.dartthat runs the real edit flow (transactionSelect→updateTransaction) against the test DB. On currentmainboth tests fail:2024-01-01, actual2025-05-20(the staleselectedDateProvidervalue)null, actual2027-01-01🧪 Testing Instructions
Behaviour
dart format,flutter analyzeandflutter test --concurrency=1all pass locally (Flutter 3.38.8).🔍 Checklist for reviewers