poppler: move to explicit dependencies of box - #3208
Conversation
|
what's the motivation for this change? |
|
Keeping the base smaller. We should only install poppler if it's needed, since I don't think it makes sense to be in the base. |
dc26a6e to
fcbae86
Compare
|
@hackbar can you please provide a little more information about your testing? What platforms did you build for and runtime test on? I am just concerned about the scenario where another package on a given platform omitted the dependency and because it was pulled in globally still built fine. |
|
I tested both a full build and a base only build, on SM6115, on a MANGMI Air X. |
|
Just want to make sure it doesn't break the build on any platform. Have kicked off builds: https://github.com/ROCKNIX/distribution/actions/runs/33702310916 |
|
Sure, always good to get more eyes on changes. |
|
This will longer be installed on AMD64 with this change. |
|
That seems good, right? We don't want a PDF reader in the base install unless an app needs it? |
|
How does emulation station load PDFs (game manuals)? |
|
Oh, nice catch, emulation station didn't include poppler as its dependency, even though it uses it. I added a separate commit to fix that. Are there any other programs that might use PDFs who dependencies we should check? |
d06c8a7 to
fca9457
Compare
|
This is not a breaking change nevertheless, I'm not sure why poppler is needed at all, I can't see it as a dependency optional or required of box86, box64 or wine. It requires a bunch of other packages to be built and would simplify the build process if it was dropped entirely. |
|
I'm fine with dropping it entirely, but maybe start with this change first? It'll at least take it out of the base build, and only packages that need it will trigger its inclusion. |
|
Oh, you mean why does box64 need it? I'm not sure, someone in the discord said it's needed by box. |
|
Your changes wont take it out of the base build as emulation station is included in all builds. ie EMULATION_DEVICE=yes/no |
|
Sorry, I meant a BASE_ONLY=true install without emulationstation. |
It's shelled out to for loading PDFs.
Summary
remove poppler from the virtual package
Testing
building, both base and full image.
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO