Skip to content

poppler: move to explicit dependencies of box - #3208

Open
hackbar wants to merge 2 commits into
ROCKNIX:nextfrom
hackbar:poppler
Open

poppler: move to explicit dependencies of box#3208
hackbar wants to merge 2 commits into
ROCKNIX:nextfrom
hackbar:poppler

Conversation

@hackbar

@hackbar hackbar commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • What is the goal of this PR? (e.g. Bump up an emulator version, implement a new feature. )
    remove poppler from the virtual package

Testing

  • How was this tested? (e.g. Built and tested on specific devices, manual testing steps, URLs for CI/CD build artifacts.)
  • Test results: (e.g. Screenshots, logs, performance metrics if applicable.)
    building, both base and full image.

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on.)

AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@loki666

loki666 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

what's the motivation for this change?

@hackbar

hackbar commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Keeping the base smaller. We should only install poppler if it's needed, since I don't think it makes sense to be in the base.

@hackbar
hackbar force-pushed the poppler branch 3 times, most recently from dc26a6e to fcbae86 Compare September 1, 2026 01:01
@porschemad911

Copy link
Copy Markdown
Contributor

@hackbar can you please provide a little more information about your testing? What platforms did you build for and runtime test on? I am just concerned about the scenario where another package on a given platform omitted the dependency and because it was pulled in globally still built fine.

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

I tested both a full build and a base only build, on SM6115, on a MANGMI Air X.

@porschemad911 porschemad911 self-assigned this Sep 3, 2026
@porschemad911

Copy link
Copy Markdown
Contributor

Just want to make sure it doesn't break the build on any platform. Have kicked off builds: https://github.com/ROCKNIX/distribution/actions/runs/33702310916

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Sure, always good to get more eyes on changes.

@r3claimer

Copy link
Copy Markdown
Contributor

This will longer be installed on AMD64 with this change.

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

That seems good, right? We don't want a PDF reader in the base install unless an app needs it?

@r3claimer

Copy link
Copy Markdown
Contributor

How does emulation station load PDFs (game manuals)?

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Oh, nice catch, emulation station didn't include poppler as its dependency, even though it uses it. I added a separate commit to fix that.

Are there any other programs that might use PDFs who dependencies we should check?

@hackbar
hackbar force-pushed the poppler branch 2 times, most recently from d06c8a7 to fca9457 Compare September 3, 2026 03:10
@spycat88

spycat88 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This is not a breaking change nevertheless, I'm not sure why poppler is needed at all, I can't see it as a dependency optional or required of box86, box64 or wine.

It requires a bunch of other packages to be built and would simplify the build process if it was dropped entirely.

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

I'm fine with dropping it entirely, but maybe start with this change first? It'll at least take it out of the base build, and only packages that need it will trigger its inclusion.

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Oh, you mean why does box64 need it? I'm not sure, someone in the discord said it's needed by box.

@spycat88

spycat88 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Your changes wont take it out of the base build as emulation station is included in all builds. ie EMULATION_DEVICE=yes/no

@hackbar

hackbar commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I meant a BASE_ONLY=true install without emulationstation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants