Skip to content

dolphin-sa: prefer full controller GUID in scripts - #3265

Open
beebono wants to merge 1 commit into
ROCKNIX:nextfrom
beebono:dolphin-sdl3-guid-fix
Open

dolphin-sa: prefer full controller GUID in scripts#3265
beebono wants to merge 1 commit into
ROCKNIX:nextfrom
beebono:dolphin-sdl3-guid-fix

Conversation

@beebono

@beebono beebono commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • What is the goal of this PR? (e.g. Bump up an emulator version, implement a new feature. )

Actually matches the correct SDL3 controller string a device provides instead of defaulting to the first one seen in the list with a zeroed GUID.

Testing

  • How was this tested? (e.g. Built and tested on specific devices, manual testing steps, URLs for CI/CD build artifacts.)
  • Test results: (e.g. Screenshots, logs, performance metrics if applicable.)

Tested on Odin 2 and custom T618 build, controls still work.

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on.)

Need verification from an AyaNeo device (I don't own one, sorry) before I can call this a proper fix.


AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? YES
Diagnosed and corrected logic with Claude Code

@porschemad911

Copy link
Copy Markdown
Contributor

@beebono What's the issue that this fixes? Are dolphin-sa controls broken on inputplumber devices ATM?

@beebono

beebono commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Some of them, yes. Particularly AyaNeo devices have been reported as an issue with Dolphin matching the wrong name because of it stopping at the first match for multiple GUIDs in the bug reports channel. Admittedly this is a theoretical fix since I don't have one, but the logic checks out with how SDL3 handles controller names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants