dolphin-sa: prefer full controller GUID in scripts - #3265
Open
beebono wants to merge 1 commit into
Open
Conversation
Contributor
|
@beebono What's the issue that this fixes? Are dolphin-sa controls broken on inputplumber devices ATM? |
Contributor
Author
|
Some of them, yes. Particularly AyaNeo devices have been reported as an issue with Dolphin matching the wrong name because of it stopping at the first match for multiple GUIDs in the bug reports channel. Admittedly this is a theoretical fix since I don't have one, but the logic checks out with how SDL3 handles controller names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Actually matches the correct SDL3 controller string a device provides instead of defaulting to the first one seen in the list with a zeroed GUID.
Testing
Tested on Odin 2 and custom T618 build, controls still work.
Additional Context
Need verification from an AyaNeo device (I don't own one, sorry) before I can call this a proper fix.
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES
Diagnosed and corrected logic with Claude Code