Skip to content

Add class of OpenTenCoefficientCompressor#10

Open
annahalle wants to merge 1 commit into
4-add-validation-based-on-optihorstfrom
9_adap_tencoefficientcompressor_for_open_drive_compressors
Open

Add class of OpenTenCoefficientCompressor#10
annahalle wants to merge 1 commit into
4-add-validation-based-on-optihorstfrom
9_adap_tencoefficientcompressor_for_open_drive_compressors

Conversation

@annahalle

Copy link
Copy Markdown
Contributor

Open compressors are driven by an external electric motor. Thus, mechanical power is given by 10 coefficient polynomials instead of electrical power. TenCoefficientCompressor is adapted to polynomials calculating mechanical power

Open compressors are driven by an external electric motor. Thus, mechanical power is given by 10 coefficient polynomials. TenCoefficientCompressor is adapted to polynomials calculating mechanical power
@annahalle
annahalle requested a review from jukkl July 16, 2024 14:12
@FWuellhorst

Copy link
Copy Markdown

@annahalle Nice, thanks for the new feature. Have you considered just adding a new parameter to the default TenCoefficientCompressor with eta_el=1 as the default?
Or, you could inherit TenCoefficientCompressor and just overwrite calc_electrical_power like this (and overwrite __init__ to add self.assumed_eta_el

    def calc_electrical_power(self, inputs: Inputs, fs_state: FlowsheetState) -> float:
        p_mech = super().calc_electrical_power(inputs=inputs, fs_state=fs_state)
        p_el = p_mech / self.assumed_eta_el
        return p_el

Either way, I just changed some logic in TenCoefficientCompressor in another branch, as T_sc is only required for capacity definition heating. Also, I changed an error when assuming bad eta_mechs. Using inheritance would add these fixes directly to your class, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants