fix: bridge quote fetch - #4079
Merged
Merged
Conversation
hz002
marked this pull request as draft
September 7, 2026 06:50
Contributor
PR扫描结果依赖变更
详细风险信息@rabby-wallet/rabby-api @ 0.9.66-alpha.0
@rabby-wallet/rabby-bridge @ 0.0.9-alpha.0
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
hz002
marked this pull request as ready for review
September 10, 2026 09:30
Contributor
PR扫描结果依赖变更
详细风险信息@rabby-wallet/rabby-api @ 0.9.66
@rabby-wallet/rabby-bridge @ 0.0.9
|
![rabby-code-reviewer[bot]](https://avatars.githubusercontent.com/u/84845472?s=60&v=4){kind=small}
| "@rabby-wallet/rabby-api": "0.9.65", | ||
| "@rabby-wallet/rabby-bridge": "0.0.8", | ||
| "@rabby-wallet/rabby-api": "0.9.66", | ||
| "@rabby-wallet/rabby-bridge": "0.0.9", |
Contributor
There was a problem hiding this comment.
Non-blocking/security: @ddddhm1234, this PR updates bridge/API dependencies and their lockfile checksums; please perform the required dependency and supply-chain security review.
| "@rabby-wallet/rabby-api": "0.9.65", | ||
| "@rabby-wallet/rabby-bridge": "0.0.8", | ||
| "@rabby-wallet/rabby-api": "0.9.66", | ||
| "@rabby-wallet/rabby-bridge": "0.0.9", |
Contributor
There was a problem hiding this comment.
Non-blocking/correctness: @rabby-wallet/rabby-bridge 0.0.9 now always forwards slippage to getBridgeQuoteListV2. The current Bridge hook derives that value with new BigNumber(slippageObj.slippageState).div(100).toString(10); closing the custom-slippage editor with a blank value commits "", which becomes the truthy string "NaN", passes the package’s requireSlippage check, and makes the quote requests fail/return no quotes. Please use the normalized slippageObj.slippage fallback here and reject non-finite slippage before invoking the package.
cs1707
approved these changes
Sep 11, 2026
Contributor
PR扫描结果依赖变更
详细风险信息@rabby-wallet/rabby-api @ 0.9.66
@rabby-wallet/rabby-bridge @ 0.0.10
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.