fix: support trusted warp sync checkpoints on release v500 - #3122
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/repository scrutiny, mitigated by admin permission and substantial merged history; no Gittensor association found; integration branch fix/finney-light-sync-checkpoint-v500 → release-v500. Static review found the nine changed files byte-identical to the previously reviewed and merged #3113 implementation. The checkpoint remains explicitly chain-spec anchored, validates its transition shape and authority set, and the generator RPC is opt-in. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability was found in the PR-specific changes. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association UNKNOWN; very new account, but admin permission and substantial repository contribution history warrant established-contributor calibration. The implementation matches the substantive PR description and is identical to the previously reviewed #3113 change. The checkpoint is chain-spec anchored and validated, while its generator RPC remains explicitly opt-in. Quick checks passed: FindingsNo findings. ConclusionThe release-branch port preserves the reviewed checkpoint behavior and includes focused validation and regression coverage. No blocking domain issues were found. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Summary
Ports the trusted Finney GRANDPA warp-sync checkpoint fix from #3113 onto the
release-v500branch used by #3117.grandpaWarpSyncCheckpointchain-spec extension containing a historical GRANDPA transition header and the authority set that signed itgrandpa_genWarpSyncCheckpointresponse behind the opt-in--enable-warp-sync-checkpoint-rpcflaggrandpaWarpSyncCheckpointwhenever the raw and plain chain specs are rebuiltAddresses #3112.
Cause and user impact
Finney's historical GRANDPA set-ID discontinuity causes otherwise valid warp proofs to be rejected during bootstrap. A full sync bypasses warp verification but is not a practical replacement for lite-node operation. This change supplies a trusted historical signing boundary in the Finney chain spec, after which ordinary GRANDPA transitions continue to be verified from the proof chain.
Trust and compatibility
Validation
cargo fmt --check --allbash -n scripts/build_all_chainspecs.shgit diff --check origin/release-v500...HEADSKIP_WASM_BUILD=1 cargo check -p node-subtensor --lib--sync=warp, imported current state, reported GRANDPA set ID 6, reachedisSyncing: false, and continued finalizing blocks