Skip to content

feat: add tiered attestation scoring#1440

Merged
shariqnaiyer merged 6 commits into
ReamLabs:masterfrom
perfogic:feat/tiered-attestation-scoring
Jul 5, 2026
Merged

feat: add tiered attestation scoring#1440
shariqnaiyer merged 6 commits into
ReamLabs:masterfrom
perfogic:feat/tiered-attestation-scoring

Conversation

@perfogic

@perfogic perfogic commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

What was wrong?

Closes #1437. Ream only had the round-based block builder. leanSpec #1149 adds a tiered selection strategy that prioritizes attestations by Finalize > Justify > Build.

What has been done

  • Added a --block-production <round-based|tiered> flag (default round-based) to pick the strategy at runtime.
  • Ported the tiered scoring logic with tests for tier ordering, proof-union emission, and an end-to-end smoke test.

What need to know

  • build_block dispatches on the strategy; see select_tiered and seal_block.
  • Ream does not keep aggregated_payloads as global state. on_block stores proofs by (validator_id, data_root), so select_tiered rebuilds the proof pool before scoring.
  • The selector does not run select_proofs_for_coverage; proof selection/compaction are delegated to select_aggregated_proofs + compact_aggregated_proofs. Because of that, select_tiered emits the full proof union while scoring/projection use only new_voters.

To-Do

@perfogic perfogic changed the title feat(fork-choice): add tiered attestation scoring feat: add tiered attestation scoring Jun 17, 2026
@shariqnaiyer

Copy link
Copy Markdown
Collaborator

Please make this modular as per
leanEthereum/leanSpec#1149

@shariqnaiyer

shariqnaiyer commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

I will leave the architecture of how you want to select the strategy up to your judgement

@perfogic

perfogic commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

great, thanks. Will follow the modular 👍

@perfogic
perfogic force-pushed the feat/tiered-attestation-scoring branch 2 times, most recently from 4bb9c0b to 965131d Compare June 18, 2026 01:37
@perfogic
perfogic marked this pull request as ready for review June 18, 2026 03:11
@shariqnaiyer

Copy link
Copy Markdown
Collaborator

@perfogic please rebase

@perfogic
perfogic force-pushed the feat/tiered-attestation-scoring branch from 7183d93 to 872965a Compare June 24, 2026 14:34
@perfogic
perfogic force-pushed the feat/tiered-attestation-scoring branch from afea767 to 17f9a3d Compare June 25, 2026 10:33

@Kayden-ML Kayden-ML left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good nice work I just gave this through review but can you run make pr before this is merged into master so it updates the book-cli-check

@perfogic

perfogic commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator Author

@Kayden-ML Thanks for reviewing, i ran make pr and updated the check-cli-docs output.

@shariqnaiyer
shariqnaiyer added this pull request to the merge queue Jul 5, 2026
Merged via the queue into ReamLabs:master with commit c30a9c9 Jul 5, 2026
32 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tiered attestation scoring as selectable alternative to improve block building performance

3 participants