fix: deserialize engine_getPayloadV4 response#1475
Draft
IvanBelyakoff wants to merge 1 commit into
Draft
Conversation
…ouldOverrideBuilder rename)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PayloadV4fails to deserialize a spec-compliantengine_getPayloadV4response from a real EL:block_valueis the ELblockValueQUANTITY (e.g."0x0"), not a 32-byte hash. TypedB256it never deserializes; changed toU256withserde_utils::u256_hex_be.should_overide_builderis misspelled, so its derived camelCase name (shouldOverideBuilder) does not match the EL'sshouldOverrideBuilder. Added#[serde(rename)].Updates the one beacon-side reader accordingly. Marked draft.