feat: ensure attestation source slot does not exceed target#1486
Open
zemse wants to merge 6 commits into
Open
Conversation
Contributor
|
can you rebase this |
…ead_chain_not_store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Ream already uses source from the head chain for voting. But we are missing:
source.slot <= target.slotsanity guard inproduce_attestation_dataCloses #1448.
How was it fixed?
produce_attestation_datavalidate_checksrun_attestation_pipelinevalidation replaced withstore.on_gossip_attestationbecausevalidate_checksdepend on voting state recorded inattestation_signatures.is_aggregatoris added toForkChoiceStep::Attestationtype which is used in the test vectorvalidator_idis set to0to enable the store to become aggregatortest_honest_vote_sources_from_head_chain_not_storevector introduced in lean spec upstream.Click to see screenshot of tests
Devnet 5 test vector passing:

Devnet 4 tests remain unaffected:

To-Do