fix(lean): reject malformed justification state with typed errors#1496
Open
perfogic wants to merge 3 commits into
Open
fix(lean): reject malformed justification state with typed errors#1496perfogic wants to merge 3 commits into
perfogic wants to merge 3 commits into
Conversation
73b1436 to
be75fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
Address leanSpec #1178
TLDR:
is_justifiable_afteris now total: below-finalized slots returnfalseinstead of erroring, and the fixture runner supports signed deltas for those cases.process_attestationsnow rejects malformed justification bookkeeping before unpacking, including vote-list length mismatch and zero-hash roots.How was it fixed?
is_justifiable_aftertotal by returningfalsefor slots before finalization.To-Do