Skip to content

fix: backfill race condition and lean-spec-tests in hive#1513

Open
Sahilgill24 wants to merge 2 commits into
ReamLabs:masterfrom
Sahilgill24:fix/backfill-race-condition
Open

fix: backfill race condition and lean-spec-tests in hive#1513
Sahilgill24 wants to merge 2 commits into
ReamLabs:masterfrom
Sahilgill24:fix/backfill-race-condition

Conversation

@Sahilgill24

@Sahilgill24 Sahilgill24 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What was wrong?

All the changes mentioned in the Hive ream tests doc

How was it fixed?

  • adding the check for preventing the race condition, if the only peer available is the one in Reset rather than earlier going into an infinite loop and get stuck in syncing, try to reuse it if it is the only one available rather than hard rejection on the peer
  • use the MOCK_PROOF_PREFIX from the leanSpec for mock proof aggregation in the test driver
  • adding proper alias for relevant exception fields and tick related fields.

All 117 fork choice spec tests and all the state transition tests are now passing, earlier about 39 of these in total were failing on hive.

[Fork Choice]
image

[State Transition]
image

To-Do

@shariqnaiyer

Copy link
Copy Markdown
Collaborator

@Sahilgill24 Could you please ensure cargo/udeps ci passes. I am reviewing the PR in the meantime.

@Sahilgill24

Copy link
Copy Markdown
Collaborator Author

@shariqnaiyer , as mentioned in the CI of cargo-udeps it is a false positive, because these crates are being used under the devnet5 feature flag and the default for this crate is devnet-4, so that is what is causing the issue I believe

@shariqnaiyer

Copy link
Copy Markdown
Collaborator

@shariqnaiyer , as mentioned in the CI of cargo-udeps it is a false positive, because these crates are being used under the devnet5 feature flag and the default for this crate is devnet-4, so that is what is causing the issue I believe

I believe there is certainly a way to make the ci green. I would rebase the PR as the devnet4 removal is merged and give it another shot. I can take a look if it's still causing problems when I wake up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants