ENH: __verify_trigger method and tests implementation#956
Open
juliomachad0 wants to merge 2 commits intoenh/eventsfrom
Open
ENH: __verify_trigger method and tests implementation#956juliomachad0 wants to merge 2 commits intoenh/eventsfrom
juliomachad0 wants to merge 2 commits intoenh/eventsfrom
Conversation
…out_of_rail_trigger to pass in __verify_trigger Co-authored-by: Copilot <copilot@github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/events #956 +/- ##
=============================================
Coverage ? 81.06%
=============================================
Files ? 108
Lines ? 13948
Branches ? 0
=============================================
Hits ? 11307
Misses ? 2641
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCurrent behavior
Verify triggers function not implemented yet.
New behavior
The verify_triggers method was implemented, trying to follow the instructions presented in the TODO. Also, an adaptation of the out_of_rail_trigger method in order to pass in the tests (following the defined standards)
Breaking change