Add Counter and Feedback KDFs from NIST SP 800-108#202
Open
SalusaSecondus wants to merge 6 commits intoRustCrypto:masterfrom
Open
Add Counter and Feedback KDFs from NIST SP 800-108#202SalusaSecondus wants to merge 6 commits intoRustCrypto:masterfrom
SalusaSecondus wants to merge 6 commits intoRustCrypto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt to implement some of the NIST SP 800-108 KDFs as requested in #75 . That standard defines a large family of KDFs and so rather than defining a single construction, I needed a way for developers to configure the specific KDF they need. I'm doing this with an enum called
ContextComponentwhich allows them to build up a specific context. To avoid memory allocation, I place a hard cap at 16 elements, though expect 5 to be sufficient in practice.While I have added test vectors from CAVP for these cases, they do not cover all of the configurations described in the standard. Specifically, they do not cover encoding the length of the output nor use of K0. Please double-check my logic and implementation around these.
I have not added implementations of either Double Pipeline or KMAC KDFs at this time.
As always, all naming (struct, crate, etc.) is up for change.