Optical sim/reco updates#892
Open
mvicenzi wants to merge 142 commits into
Open
Conversation
…plate It used to end when the template SPR goes under 1e-4 ADC#. Now it needs to stay within +/- 1w-4 ADC# for 20 nanoseconds. This should make it possible to include undershootings. All these parameters are currently hard-coded.
…icles that might cross cathode
Good catches on names and strings. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Trigger simulation modules now support input tags with process name [private]
Replaces the functionality of the "generalist" OverlayProducts module (which has overlapping detection broken and hard-coded simulation baselines, things that can be in principle fixed). This module does the minimum it has to in order to make the overlay workflow work and flow. Overlay job configuration is changed to adopt it.
A new configuration of DetectorClocksService is introduced for simulation workflows. A drop-in override is provided (`override_services_for_simulation.fcl`). Stage0, Stage1, CAF and overlay configurations are updated to use it.
Includes the change of discrimination threshold from Run1 (400 ADC#) to Run2 standard (390 ADC#) and internal adjustments.
Enabled by the change in PMTsimulationAlg that produces the baselines.
… gate time In the plain simulation, defined as the one performed with standard DetectorClocks configuration, simulation time and beam time scales coincide. Introducing a time scale shift in the workflow, we redefine the beam gate time, adding a margin before the beam, which separates the two scales. The beam gate produced at generation stage refers to simulation time, as all the gates derived by it do.
The beam gate start time in raw::Trigger et al. assumed the input gate to be in the (current) beam gate time scale, but that may be not true. The gate is always output in electronics time anyway.
This accounts for the average time it takes the hardware trigger to emit a response. Beam gates may need to be corrected accordingly, as the beam gate start time is not subject to this delay. The delay is encoded in the configurations for Run2. The value, obtained by visual calibration, is statistically compatible with the one from Run3.
It is now the same for simulation as it is for data.
* added `--suffix` and `--and` options * explicit support for compressed raw data, "raw" became uncompressed only
…ure/gp_overlayFix
[private] consolidating pmt updates from feature/gp_overlayFix
This was referenced May 18, 2026
mvicenzi
changed the base branch from
feature/mvicenzi_repro_step1
to
release/SBN2025A
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the required updates and fhicls to enable the reprocessing of light products for the SBN2025 spring productions (both MC and data). In particular, it includes fixes to the trigger/overlays procedure, as well as model improvements such as the use of time-dependent gain and pmt status databases.
Some highlights:
shiftedtrigger referenceDetectorClocksServiceconfiguration overrides for simulationdetsimoverlaysdetsimandstage0detsimandstage0for MC-overlays/datadetsimmoduleThis PR requires three
icarus_dataupdates:pmt_speareas_data.dbtov1r2pmt_voltage_data.dbtov1r3This PR depends on:
(this PR includes developements previously discussed in #876 and #785 )