Skip to content

TrackCaloSkimmer object: include changed#540

Merged
kjplows merged 3 commits into
developfrom
feature/fp_bugFix
May 8, 2025
Merged

TrackCaloSkimmer object: include changed#540
kjplows merged 3 commits into
developfrom
feature/fp_bugFix

Conversation

@francescopoppi
Copy link
Copy Markdown
Contributor

In develop by mistake the include for CRTT0TaggingInfo and CRTT0TaggingTruthInfo were point to the wrong file: .cc instead of .hh
This PR fixes that.

@francescopoppi francescopoppi self-assigned this May 7, 2025
@francescopoppi francescopoppi added the bugfix Addresses one or more bugs label May 7, 2025
Copy link
Copy Markdown
Contributor

@kjplows kjplows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented May 7, 2025

trigger build

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

Copy link
Copy Markdown
Contributor

@nathanielerowe nathanielerowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@FNALbuild
Copy link
Copy Markdown

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored failure for unit_test -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development May 7, 2025
@kjplows kjplows merged commit 40bade6 into develop May 8, 2025
4 of 6 checks passed
@github-project-automation github-project-automation Bot moved this from To merge to Done in SBN software development May 8, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development May 8, 2025
@kjplows kjplows changed the title TrackCaloSmikker object: include changed TrackCaloSkimmer object: include changed May 8, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Jul 10, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_06_00_01 milestone Jan 16, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

4 participants