Skip to content

Bug Fix: OffBeam ICARUS Accounting, Missed an &#543

Merged
kjplows merged 2 commits into
release/SBN2024Afrom
feature/zennamo_fixoffbeam
Jul 10, 2025
Merged

Bug Fix: OffBeam ICARUS Accounting, Missed an &#543
kjplows merged 2 commits into
release/SBN2024Afrom
feature/zennamo_fixoffbeam

Conversation

@jzennamo
Copy link
Copy Markdown
Contributor

@jzennamo jzennamo commented Jul 2, 2025

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@jzennamo jzennamo requested a review from PetrilloAtWork July 2, 2025 20:43
@jzennamo jzennamo added the bug Something isn't working label Jul 2, 2025
@PetrilloAtWork
Copy link
Copy Markdown
Member

PetrilloAtWork commented Jul 2, 2025

A single-character-change PR tests my ability to always have change requests.
Let's wait in case we need more fixes: that would make my task easier.

Although to be honest I like the reference symbol & to be attached to the type rather than to the variable name... I'll keep this one as a backup.

Copy link
Copy Markdown
Member

@PetrilloAtWork PetrilloAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very bad ampersand alignment.

@kjplows
Copy link
Copy Markdown
Contributor

kjplows commented Jul 10, 2025

trigger build LArSoft/larcore@v09_11_01 LArSoft/larcorealg@v09_13_01 LArSoft/larcoreobj@v09_10_01 LArSoft/lardata@v09_16_02 LArSoft/lardataalg@v09_17_02 LArSoft/lardataobj@v09_18_02 LArSoft/larfinder@v09_00_01 LArSoft/larpandoracontent@v04_08_01 LArSoft/larsoftobj@v09_35_02 LArSoft/larvecutils@v09_04_01 LArSoft/lar*@LARSOFT_SUITE_v09_89_02 SBNSoftware/sbncode@v09_89_02 SBNSoftware/sbnobj@v09_19_00_01 SBNSoftware/sbnanaobj@v09_23_00_02 SBNSoftware/sbndaq_artdaq_core@v1_09_00of1 SBNSoftware/sbndata@v01_07 SBNSoftware/icarus*@release/SBN2024A

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Jul 10, 2025
@kjplows kjplows merged commit dc45efe into release/SBN2024A Jul 10, 2025
@github-project-automation github-project-automation Bot moved this from To merge to Done in SBN software development Jul 10, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Jul 10, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Jul 18, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the SBN2024A/v09_89_02_01 milestone Jan 16, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in PR archaeology Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

4 participants