Frame Shift Module to Correct Timing in Data - PR For Develop

[VCLanNguyen]

Description

New module for timing reconstruction in introduced at reco2 in sbndcode.
Module make data products that are saved in CAF as new Standard Record products.
Data Timing variables in CAF, i.e. crt space point time, sbnd crt track time, opflash and opt0, are shifted for beam spill reconstruction.
Full description can be found in docdb: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=43090

• Have you added a label? (bug/enhancement/physics etc.)

• Have you assigned at least 1 reviewer?

• Is this PR related to an open issue / project?

• Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.

• Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  sbnobj dev: Frame Shift Module to Correct Timing in Data - PR For Develop sbnobj#142
  sbnanaobj dev: Frame Shift Module to Correct Timing in Data - PR For Develop sbnanaobj#154
  sbndcode dev: Frame Shift Module to Correct Timing in Data - PR For Develop sbndcode#804
  sbncode dev: Frame Shift Module to Correct Timing in Data - PR For Develop #562

• Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

[PetrilloAtWork]

To be honest, all this correction business in my opinion should have been applied at reconstruction time, if not immediately at decoding time. It should be noted that this code supports the case where no shift is required, by specifying SBNDFrameShiftInfoLabel and SBNDTimingInfoLabel configuration parameters as empty.
In fact, I suggest to set those parameters as empty as default, and set them explicitly in the configuration, as an indication that the correction being done at CAF is exceptional.

I have left a few other suggestions for your consideration.
When you have made your mind on those and written your conclusion, please request the review again (and drop a Slack message about that, since GitHub notifications are easily swamped).

[kjplows]

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbnobj#142 SBNSoftware/sbnanaobj#154

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

[FNALbuild]

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

[FNALbuild]

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

[FNALbuild]

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

[PetrilloAtWork]

Approved. Thanks to @VCLanNguyen for following this PR to the end.