[Fix] 탈퇴 유저 JWT 인증 우회 및 회원탈퇴 정리 로직 정비 - #313
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📊 테스트 커버리지 리포트
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 요약
🔗 이슈
✨ 변경 내용
JwtFilter에서findById→findByIdAndDeletedFalse로 변경 - 탈퇴했거나 존재하지 않는 유저의 토큰은JWT_USER_WITHDRAWN으로 인증 실패 처리 (기존엔isSuspended()만 체크하고deleted는 검사하지 않아, 탈퇴 유저 토큰이 만료 전까지 계속 유효했음)OAuthKakaoClient.unlinkKakaoUser()연결 - 정의만 되어있고 호출되지 않던 죽은 코드를 탈퇴 시 실제로 호출하도록 연결 (원본 oauthId를 익명화 전에 확보해 provider가 KAKAO일 때만 호출)logout()과 동일하게 동기 처리로 변경 - 기존엔@Async+Thread.sleep기반 재시도로 처리되어logout()과 일관성이 없었고, 실패 시 토큰이 계속 유효한 창(window)이 생겼음. FCM 삭제/카카오 unlink 같은 외부 정리 작업은 기존처럼 비동기+재시도 유지✅ 확인